[Dialog] Make dismiss button larger and use neutral color #2565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change dismiss icon color
vnbaaij
changed the title
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Unit Tests
Details on your Workflow / Core Tests page. |
|
@vnbaaij Have you noticed that several unit tests are failing? |
Yes, working on that |
Summary - Unit Tests Code CoverageSummary
CoverageMicrosoft.FluentUI.AspNetCore.Components - 61.2%
|
dvoituron
reviewed
Aug 21, 2024
| ThreeState="false" | ||
| @bind-Value="@myValue" /> | ||
| ); | ||
| // Temporarily disable this test until we figure out how why the delay in checkbox breaks this |
There was a problem hiding this comment.
That's not a good idea :-)
Can you create another PR to fix that?
There was a problem hiding this comment.
I know what is causing the issue. Need to take a look at it with you when you are back. Won't be forgotten!
dannyldj
pushed a commit
to dannyldj/fluentui-blazor
that referenced
this pull request
Sep 26, 2024
…2565) * - Make dialog header dismiss button a bit larger - Change dismiss icon color * Update tests * Temp disable one test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2539
In accordance with the React and v3 Web Components, the dismiss icon has been enlarged to 20px (from 16px) and the color has been changed to neutral (instead of accent)
Before
After